[MBL-19537][S] Learner Dashboard - Courses widget part 2#3935
Open
[MBL-19537][S] Learner Dashboard - Courses widget part 2#3935
Conversation
refs: MBL-19537 builds: Student affects: Student release note: none
Contributor
BuildsCommit: Review findings (e4dc056)
|
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
rh12
requested review from
petkybenedek,
suhaibabsi-inst and
vargaat
as code owners
This comment was marked as outdated.
This comment was marked as outdated.
…-part-2 # Conflicts: # Student/Student/LearnerDashboard/Container/ViewModel/LearnerDashboardViewModel.swift # Student/StudentUnitTests/LearnerDashboard/Container/ViewModel/LearnerDashboardViewModelTests.swift # Student/StudentUnitTests/LearnerDashboard/Widgets/CourseInvitationsWidget/ViewModel/CourseInvitationsWidgetViewModelTests.swift
This comment was marked as outdated.
This comment was marked as outdated.
…-part-2 # Conflicts: # Student/Student/LearnerDashboard/Container/ViewModel/LearnerDashboardViewModel.swift # Student/Student/LearnerDashboard/Widgets/CourseInvitationsWidget/ViewModel/CourseInvitationsWidgetViewModel.swift # Student/Student/LearnerDashboard/Widgets/CoursesAndGroupsWidget/ViewModel/CoursesAndGroupsWidgetViewModel.swift # Student/StudentUnitTests/LearnerDashboard/Container/ViewModel/LearnerDashboardViewModelTests.swift # Student/StudentUnitTests/LearnerDashboard/Widgets/CourseInvitationsWidget/ViewModel/CourseInvitationsWidgetViewModelTests.swift
Contributor
Affected Apps: StudentBuilds: Student
|
vargaat
requested changes
Mar 16, 2026
Collaborator
vargaat
left a comment
vargaat
left a comment
There was a problem hiding this comment.
I have a user that has no courses, only an account level group. For this user the widget does not display and the "all courses" screen isn't reachable.
...rnerDashboard/Widgets/CoursesAndGroupsWidget/ViewModel/CoursesAndGroupsWidgetViewModel.swift
Show resolved
Hide resolved
...tudent/LearnerDashboard/Widgets/CoursesAndGroupsWidget/View/CoursesAndGroupsWidgetView.swift
Outdated
Show resolved
Hide resolved
...tudent/LearnerDashboard/Widgets/CoursesAndGroupsWidget/View/CoursesAndGroupsWidgetView.swift
Outdated
Show resolved
Hide resolved
rh12
changed the title
Contributor
Author
Nice catch! It turned out the request fails without any |
Contributor
Affected Apps: StudentBuilds: Student
|
vargaat
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs: MBL-19537
builds: Student
affects: Student
release note: none
Screenshots
Checklist