[MBL-19529][S] Learner Dashboard - Settings Enhancements by vargaat · Pull Request #3940 · instructure/canvas-ios

vargaat · 2026-03-16T08:45:46Z

What's new?

Added a "Customize Dashboard" button to the bottom of the dashboard.
Added an empty view informing users that all widgets are turned off.
Courses and groups settings view will hide "Show Grades" and "Show Color Overlay" toggles when the widget is turned off.
Fixed dashboard color selection tick icon not being visible in dark mode when the black/white color is selected.
Fixed edit dialog not switching between dark/light modes dynamically while the modal is open.
Voiceover no longer offers the move up and move down actions when they are disabled for widgets sitting at the top/bottom of the list.

refs: MBL-19529
builds: Student
affects: Student
release note: none

test plan:

Test if all changes work properly.

Checklist

refs: MBL-19529 builds: Student affects: Student release note: none

# Conflicts: # Student/Student/LearnerDashboard/Widgets/Common/Model/DashboardWidgetConfig.swift # Student/Student/LearnerDashboard/Widgets/Common/Model/DashboardWidgetViewModel.swift # Student/Student/LearnerDashboard/Widgets/ConferencesWidget/ViewModel/ConferencesWidgetViewModel.swift # Student/Student/LearnerDashboard/Widgets/CourseInvitationsWidget/ViewModel/CourseInvitationsWidgetViewModel.swift # Student/Student/LearnerDashboard/Widgets/CoursesAndGroupsWidget/ViewModel/CoursesAndGroupsWidgetViewModel.swift # Student/Student/LearnerDashboard/Widgets/FileUploadProgressWidget/ViewModel/FileUploadProgressWidgetViewModel.swift # Student/Student/LearnerDashboard/Widgets/GlobalAnnouncementsWidget/ViewModel/GlobalAnnouncementsWidgetViewModel.swift # Student/Student/LearnerDashboard/Widgets/HelloWidget/ViewModel/HelloWidgetViewModel.swift # Student/Student/LearnerDashboard/Widgets/OfflineSyncProgressWidget/ViewModel/OfflineSyncProgressWidgetViewModel.swift # Student/StudentUnitTests/LearnerDashboard/Container/Model/LearnerDashboardInteractorTests.swift # Student/StudentUnitTests/LearnerDashboard/Container/ViewModel/LearnerDashboardViewModelTests.swift

…//github.com/instructure/canvas-ios into feature/MBL-19529-Dashboard-simple-edit-mode # Conflicts: # Student/StudentUnitTests/LearnerDashboard/Container/ViewModel/LearnerDashboardViewModelTests.swift

refs: builds: affects: release note: test plan:

…, always visible) and EditableWidgetIdentifier (user-configurable) - Interactor now loads system widgets always, and editable widgets from merged saved+default configs filtered by visibility/order - Settings changes now save immediately to SessionDefaults and trigger a dashboard reload via onConfigsChanged callback - Widget assembly split into separate makeSystemWidgetViewModel / makeEditableWidgetViewModel factories

refs: MBL-19529 builds: Student affects: Student release note: none test plan: - Test widget settings.

…ure/MBL-19529-Learner-Dashboard-settings-save # Conflicts: # Student/Student/LearnerDashboard/Container/ViewModel/LearnerDashboardViewModel.swift # Student/Student/LearnerDashboard/Settings/LearnerDashboardSettingsAssembly.swift # Student/Student/LearnerDashboard/Settings/View/LearnerDashboardCourseSettingsView.swift # Student/Student/LearnerDashboard/Settings/ViewModel/LearnerDashboardCourseSettingsViewModel.swift # Student/StudentUnitTests/LearnerDashboard/Container/ViewModel/LearnerDashboardViewModelTests.swift

# Conflicts: # Core/Core/Common/CommonUI/InstUI/Styles/Elevation.swift

…ure/MBL-19529-Learner-Dashboard-settings-save # Conflicts: # Student/Student/LearnerDashboard/Widgets/DashboardWidgetIdentifier.swift # Student/Student/LearnerDashboard/Widgets/LearnerDashboardWidgetAssembly.swift # Student/StudentUnitTests/LearnerDashboard/Container/Model/LearnerDashboardInteractorTests.swift

…gs-save

…d off. refs: MBL-19529 builds: Student affects: Student release note: none test plan:

…ted.

bitrise · 2026-03-16T09:02:07Z

Builds

Commit: Merge branch 'master' into feature/MBL-19529-Learner-Dashboard-Settings-Enhancements (c45fc64)
Build Number: 1563
Built At: Mar 16 10:41 CET (03/16 03:41 AM MDT)

Student

…gs-Enhancements # Conflicts: # Student/Student/LearnerDashboard/Container/View/LearnerDashboardScreen.swift # Student/Student/LearnerDashboard/Container/ViewModel/LearnerDashboardViewModel.swift # Student/Student/LearnerDashboard/Settings/View/LearnerDashboardSettingsWidgetCardView.swift

bitrise · 2026-03-16T09:37:20Z

	Warnings
⚠️	This pull request will not generate a release note.
⚠️	One or more files are below the minimum test coverage 50%

Affected Apps: Student

Builds: Student

MBL-19529

Coverage	New %	Master %	Delta
Canvas iOS	91.71%	81.06%	10.64%
Core/Core/Common/CommonUI/Layout/FlexibleGrid.swift	0%	--	--

Generated by 🚫 dangerJS against c45fc64

rh12

Making any widget level changes on the Dashboard settings (show/hide or rearrange a widget) causes any further refresh to be ignored, even forced ones.
Couple of ways to test this after a PTR:

Hello message is not updating
Course favorite changes are not updaing

This was like this in the previous PR as well (noticed this on my Courses widget branch, and checked both settings PRs afterwards)

petkybenedek and others added 30 commits March 3, 2026 13:21

Create UI

d75edfe

refs: MBL-19529 builds: Student affects: Student release note: none

Merge master

aeb8276

Correct animation

3713440

Correct logic

35fdfc9

Correct tests and claude findings

bffad74

Requested changes

eb5320a

Color selector corrections

eeb566e

Merge branch 'master' into feature/MBL-19529-Dashboard-simple-edit-mode

52aac49

Remove no longer set variable tests.

2336355

Remove unnecessary test

4742afb

Merge branch 'feature/MBL-19529-Dashboard-simple-edit-mode' of https:…

3e2bca1

…//github.com/instructure/canvas-ios into feature/MBL-19529-Dashboard-simple-edit-mode # Conflicts: # Student/StudentUnitTests/LearnerDashboard/Container/ViewModel/LearnerDashboardViewModelTests.swift

Increase popver size

19bd6ab

refs: builds: affects: release note: test plan:

Add color saving.

7c4c007

Add course settings switches. Move converences to system widgets.

2afe479

Add unit tests.

70ad1d1

refs: MBL-19529 builds: Student affects: Student release note: none test plan: - Test widget settings.

Use ID based color saving.

2ed5649

Requested changes, change settings presentation logic

a7ebd90

Update unit tests.

09d93cb

Rename dashboard settings view to screen.

763f10a

Move factory methods to widget enums.

704c4d6

Also move custom settings view factory to widget id file.

3dbcdcd

Update colors.

afeca50

Update hidden widget update logic.

3bad66c

Fix unit test. Update done button color.

614361b

Merge branch 'master' into feature/MBL-19529-Dashboard-simple-edit-mode

82f547c

# Conflicts: # Core/Core/Common/CommonUI/InstUI/Styles/Elevation.swift

Implement code review suggestions.

08f384c

vargaat and others added 14 commits March 12, 2026 17:34

Merge branch 'master' into feature/MBL-19529-Learner-Dashboard-settin…

3359454

…gs-save

Shorten test file name.

df062d5

Create FlexibleGrid and place the dashboard colors in it.

617c604

Extract default course colors from interactor.

9c8dd1e

Remove unnecessary helper.

a83bbaa

Implement multiple UI related code review suggestions.

fc45bfb

Add back bottom padding.

c0f9aa0

Fix lint violation.

882f35a

Add customize dashboard button.

c6b9674

Add no widgets view.

ef05d64

Hide sub-settings view from dashboard settings if the widget is turne…

e11edec

…d off. refs: MBL-19529 builds: Student affects: Student release note: none test plan:

Fix color selection checkmark not being visible in dark mode.

e92b516

Fix edit dialog not updating when dark mode changes when being presen…

695d41e

…ted.

Hide up and down widget actions from voiceover when they are disabled.

4b18748

vargaat self-assigned this Mar 16, 2026

vargaat requested review from petkybenedek, rh12 and suhaibabsi-inst as code owners March 16, 2026 08:45

This comment was marked as outdated.

Sign in to view

Update unit tests.

0e49fc8

Base automatically changed from feature/MBL-19529-Learner-Dashboard-settings-save to master March 16, 2026 09:19

rh12 requested changes Mar 16, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MBL-19529][S] Learner Dashboard - Settings Enhancements#3940

[MBL-19529][S] Learner Dashboard - Settings Enhancements#3940
vargaat wants to merge 46 commits intomasterfrom
feature/MBL-19529-Learner-Dashboard-Settings-Enhancements

vargaat commented Mar 16, 2026

Uh oh!

This comment was marked as outdated.

bitrise bot commented Mar 16, 2026 •

edited

Loading

Uh oh!

bitrise bot commented Mar 16, 2026 •

edited by atlassian bot

Loading

Uh oh!

rh12 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

vargaat commented Mar 16, 2026

What's new?

Checklist

Uh oh!

This comment was marked as outdated.

bitrise bot commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Builds

Uh oh!

bitrise bot commented Mar 16, 2026 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Affected Apps: Student

Builds: Student

Uh oh!

rh12 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bitrise bot commented Mar 16, 2026 •

edited

Loading

bitrise bot commented Mar 16, 2026 •

edited by atlassian bot

Loading