default an explicitly passed priority of nil to the default priority#21
Merged
ccutrer merged 1 commit intoinstructure:mainfrom Oct 2, 2025
Merged
Conversation
Contributor
Author
|
@ccutrer - Any reason this was closed without merging or comment? I'm still monkey patching it around... |
Member
|
Apologies. I was thinking this was a mistake PR that should have gone to Gerrit. |
ccutrer
force-pushed
the
aboyd/handle-nil-priorities
branch
from
1473576 to
7266c2e
Compare
ccutrer
approved these changes
Sep 30, 2025
ccutrer
force-pushed
the
aboyd/handle-nil-priorities
branch
from
7266c2e to
810d608
Compare
ccutrer
previously approved these changes
Sep 30, 2025
ccutrer
force-pushed
the
aboyd/handle-nil-priorities
branch
from
810d608 to
9e2219b
Compare
ccutrer
force-pushed
the
aboyd/handle-nil-priorities
branch
from
9e2219b to
5546c9b
Compare
aogata-inst
approved these changes
Oct 1, 2025
rmsy
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopening #12 which I somehow managed to accidentally close.
Any chance of getting this merged? I'm monkey patching around it in 3 separate projects now.