v9: backport new error messages from v10 #1767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
balzss
force-pushed
the
v9/new-form-error-style
branch
2 times, most recently
from
ed37149 to
b92d67d
Compare
balzss
changed the title
balzss
force-pushed
the
v9/new-form-error-style
branch
from
b92d67d to
e8c6da1
Compare
git-nandor
approved these changes
Nov 12, 2024
matyasf
requested changes
Nov 12, 2024
Collaborator
matyasf
left a comment
matyasf
left a comment
There was a problem hiding this comment.
CheckboxGroup and RadioInputGroup has messages in the wrong place, on master they are above the controls, in the PR below. Which one is right?
balzss
force-pushed
the
v9/new-form-error-style
branch
from
e8c6da1 to
4c823e7
Compare
Contributor
Author
good catch! the one in master is correct. fixed it |
matyasf
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INSTUI-4355
also backported a fix for the gh pages deploy action
test plan: