feat(ui-color-picker,ui-color-utils): add callback for contrast validation information and export validation methods #1768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
matyasf
requested changes
Nov 13, 2024
Collaborator
matyasf
left a comment
matyasf
left a comment
There was a problem hiding this comment.
nice work, just some small documentation fixes from me
HerrTopi
force-pushed
the
color-contrast-callback
branch
from
9be2860 to
55793ac
Compare
HerrTopi
force-pushed
the
color-contrast-callback
branch
from
55793ac to
10cea9d
Compare
…ation information and export validation methods Closes: INSTUI-4360
HerrTopi
force-pushed
the
color-contrast-callback
branch
from
10cea9d to
8007d66
Compare
balzss
approved these changes
Nov 14, 2024
matyasf
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TEST_PLAN:
check if contrast calculation works as before for ColorContrast.
Test if you pass the onContrastChange callback, to ColorContrast or ColorPicker, it really gets called when the color changes.
Check if preciously internally used methods work as before in color utils
Check if validationLevel prop does what it says
Closes: INSTUI-4360