Skip to content

feat(shared-types,ui-buttons): add theme variables for default and hover states for buttons#1840

Merged
HerrTopi merged 1 commit intomasterfrom
iconbuttonshadow
Jan 10, 2025
Merged

feat(shared-types,ui-buttons): add theme variables for default and hover states for buttons#1840
HerrTopi merged 1 commit intomasterfrom
iconbuttonshadow

Conversation

@HerrTopi
Copy link
Contributor

@HerrTopi HerrTopi commented Jan 7, 2025

Closes: INSTUI-4421

@HerrTopi HerrTopi requested review from joyenjoyer and matyasf January 7, 2025 17:35
@github-actions
Copy link

github-actions bot commented Jan 7, 2025

PR Preview Action v1.5.0
Preview removed because the pull request was closed.
2025-01-10 03:39 UTC

@matyasf
Copy link
Collaborator

matyasf commented Jan 8, 2025

Can you expand the example here? https://instructure.design/pr-preview/pr-1840/#Button/#Styling%20buttons

Copy link
Collaborator

@matyasf matyasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Copy link
Contributor

@joyenjoyer joyenjoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

@matyasf matyasf requested a review from a team January 9, 2025 08:28
Copy link
Contributor

@igera93 igera93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change, I checked and it's exactly what I needed ;)

@HerrTopi HerrTopi merged commit 43fde61 into master Jan 10, 2025
11 checks passed
@HerrTopi HerrTopi deleted the iconbuttonshadow branch January 10, 2025 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants