Conversation
Closes: INSTUI-4234 TEST PLAN: Check the icons in the docs, check all 3 formats
|
balzss
approved these changes
Feb 3, 2025
Contributor
balzss
left a comment
balzss
left a comment
There was a problem hiding this comment.
the new icons are working great but the contributor docs are out of date. they should be updated in a future PR. issue number: INSTUI-4437
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: INSTUI-4234
Also moved the icon adding docs to contributor guidelines. It was under the ui-icons package docs which is hard to find.
Also deleted ther 'drilldown menu' pattern page, we have the Drilldown component since 2 years instead
TEST PLAN:
Check the icons in the docs, check all 3 formats