Skip to content

fix(ui-time-select): make allowClearingSelection an optional prop #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matyasf merged 1 commit into from
Feb 21, 2025
Merged

fix(ui-time-select): make allowClearingSelection an optional prop #1874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ui-time-select/src/TimeSelect/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ class TimeSelect extends Component<TimeSelectProps, TimeSelectState> {
? this.state.selectedOptionId
: undefined,
fireChangeOnBlur: undefined,
isInputCleared: this.props.allowClearingSelection && value === ''
isInputCleared: this.props.allowClearingSelection! && value === ''
})
}
this.setState({
Expand Down
2 changes: 1 addition & 1 deletion packages/ui-time-select/src/TimeSelect/props.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ type TimeSelectOwnProps = {
* Whether to allow for the user to clear the selected option in the input field.
* If `false`, the input field will return the last selected option after the input is cleared and loses focus.
*/
allowClearingSelection: boolean
allowClearingSelection?: boolean
}

const propTypes: PropValidators<PropKeys> = {
Expand Down
Loading