fix(ui-file-drop): underlying HTML input's 'files' prop is now populated when dropping a file#1904
Merged
fix(ui-file-drop): underlying HTML input's 'files' prop is now populated when dropping a file#1904
Conversation
|
HerrTopi
approved these changes
Mar 17, 2025
matyasf
force-pushed
the
filedrop_dropfix
branch
from
f6e1859 to
f5530fb
Compare
joyenjoyer
approved these changes
Mar 17, 2025
…via drag and drop Browsers dont populate this field by default, one needs to do via JS INSTUI-4476
matyasf
force-pushed
the
filedrop_dropfix
branch
from
f5530fb to
42658f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default browsers do not populate the input's
filesandvalueprop when a file is dropped (its populated when clicking on the control). This PR populatesfilesprop when dropping (and thevalueprop which is calculated from this one)To test:
Drop files into a
FileDropexample, you should see thefilesobject populated in devtool's "Properties" tab or in the console.Test it with Chrome, Safari, FF
Fixes INSTUI-4476