Conversation
|
5266f4f to
abaed58
Compare
balzss
reviewed
Mar 28, 2025
| display: 'inline-flex', | ||
| alignItems: 'center' | ||
| alignItems: 'center', | ||
| margin: '0.3rem' |
Contributor
There was a problem hiding this comment.
why is this needed? and why this value?
Contributor
There was a problem hiding this comment.
instead of adding a margin here (so focusring isn't cut of), you could set the default margin to something like space8 (just make sure to use something from the new set of spacing tokens and not something like xSmall). this makes sure that when devs are implementing a design they don't have to deal with random margin around the component
Contributor
Author
There was a problem hiding this comment.
@balzss removed the 0.3rem margin and set a default 'space8' margin
abaed58 to
161d765
Compare
…prevent scrollbars INSTUI-4461
161d765 to
cfd8c40
Compare
balzss
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INSTUI-4461
ISSUE:
TEST PLAN:
test no horizontal scrollbars:
test no vertical scrollbars: