Conversation
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
packages/ui-select/src/Select/index.tsx:708
- Confirm that the condition 'utils.isAndroidOrIOS()' strictly targets iOS Chrome as intended; if Android devices do not exhibit the issue, consider refining the condition to avoid unintentional role assignment changes.
utils.isSafari() || utils.isAndroidOrIOS() ? 'button' : 'combobox',
|
matyasf
commented
Apr 9, 2025
| // Also on iOS Chrome with role='combobox' it announces unnecessarily | ||
| // that its 'read-only' and that this is a 'textfield', see INSTUI-4500 | ||
| role: | ||
| utils.isSafari() || utils.isAndroidOrIOS() ? 'button' : 'combobox', |
Collaborator
Author
There was a problem hiding this comment.
This is the fix. When we use combobox role, it doesnt seem to change the role of the trigger element itself, just speaks extra stuff like that it can be opened. If we use the button role, it does not announce that its actually an input, and neither that its read-only.
On Android sadly its still broken (so no change), I did not use something like isIOS because I want to minimize the number of different browser detectors.
joyenjoyer
approved these changes
Apr 9, 2025
ToMESSKa
approved these changes
Apr 15, 2025
…eSelect announcing 'readonly' and 'textinput' Also fix formFieldLayout spacing issue if there are multiple messages and the first one is an empty string Fixes INSTUI-4500
matyasf
force-pushed
the
fix_select_readonly_ios
branch
from
9ebde49 to
3a6e1c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix formFieldLayout spacing issue if there are multiple messages and the first one is an empty string
To test:
Check Select read-only, SimpleSelect, TimeSelect examples with VoiceOver on iOS and Desktop. It should never say 'Read-only'
Fixes INSTUI-4500