Conversation
HerrTopi
requested review from
ToMESSKa,
balzss,
git-nandor,
joyenjoyer and
matyasf
|
git-nandor
approved these changes
Apr 10, 2025
HerrTopi
commented
Apr 10, 2025
| const { containsTruncateText, hasVisibleChildren } = state | ||
| const inverseStyle = color === 'link-inverse' | ||
|
|
||
| const variantStyles = { |
Contributor
Author
There was a problem hiding this comment.
These are indeed in the styles file. I don't know what you mean
joyenjoyer
approved these changes
Apr 10, 2025
matyasf
reviewed
Apr 10, 2025
HerrTopi
force-pushed
the
link-variant
branch
2 times, most recently
from
b6ce6a2 to
c2152d6
Compare
balzss
approved these changes
Apr 10, 2025
matyasf
requested changes
Apr 10, 2025
HerrTopi
force-pushed
the
link-variant
branch
2 times, most recently
from
4658f44 to
3da2404
Compare
matyasf
approved these changes
Apr 10, 2025
Collaborator
matyasf
left a comment
matyasf
left a comment
There was a problem hiding this comment.
2 small things:
- Link font size does not come from the theme, this is a bit strange to me
- The gap between the icon and the text is the same for all sizes, is this OK?
INSTUI-4506
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TEST_PLAN:
Check the ticket and if it's criteria is met. Check the README and if the explanation is it's understandable
INSTUI-4506