test(ui-source-code-editor): migrate old SourceCodeEditor tests#1943
Merged
git-nandor merged 1 commit intomasterfrom Apr 29, 2025
Merged
Conversation
|
ToMESSKa
reviewed
Apr 17, 2025
|
|
||
| expect(allGutterElements[1]).toHaveClass('cm-activeLineGutter') |
Contributor
There was a problem hiding this comment.
the old test checks allGutterElements[0] instead if 1, but I'm not sure it's important
Contributor
Author
There was a problem hiding this comment.
The first gutter element is always a hidden element.
With the old Karma tests, the selector worked differently.
ToMESSKa
reviewed
Apr 17, 2025
Comment on lines
-338
to
-345
|
|
||
| it('should not wrap lines by default', async () => { | ||
| await mount(<SourceCodeEditor label="foo" defaultValue={longText} />) | ||
| const editor = await SourceCodeEditorLocator.find() | ||
| const scroller = await editor.findScroller() | ||
| const { scrollWidth, clientWidth } = scroller.getDOMNode() | ||
|
|
||
| expect(scrollWidth > clientWidth).to.be.true() | ||
| }) |
Contributor
There was a problem hiding this comment.
I cannot find new version of this.
Contributor
Author
There was a problem hiding this comment.
It has been moved under the Cypress tests, combining the two cases: wrap and no wrap
it('should wrap lines when lineWrapping is true'
git-nandor
force-pushed
the
INSTUI-4505_convert_ui-source-code-editor_to_the_new_test_format
branch
from
05920e5 to
ad6ad8d
Compare
balzss
approved these changes
Apr 24, 2025
ToMESSKa
approved these changes
Apr 25, 2025
git-nandor
deleted the
INSTUI-4505_convert_ui-source-code-editor_to_the_new_test_format
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.