Conversation
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
packages/ui-date-input/src/DateInput2/index.tsx:229
- The function name 'getDateFromatHint' appears to have a typo. Consider renaming it to 'getDateFormatHint' for clarity.
const getDateFromatHint = () => {
|
ToMESSKa
requested changes
Apr 17, 2025
Contributor
ToMESSKa
left a comment
There was a problem hiding this comment.
If I provide an invalid timezone like "Invalid/Timezone", it does not give an error anymore. It might be worth noting this in the documentation.
matyasf
requested changes
Apr 17, 2025
matyasf
approved these changes
Apr 29, 2025
Contributor
Author
@ToMESSKa after some considerations, I think the new behaviour is actually more logical since it falls back to the default. But if it causes confusion in the future, I'll extend the docs |
ToMESSKa
approved these changes
May 6, 2025
4734f96 to
81dfa4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INSTUI-4498
test plan
Etc/GMT+4,Etc/GMT+5,Etc/GMT-10, etc.) -> the placeholder should never break