style(ui-view): improve view border colors#1953
Merged
Conversation
INSTUI-4532
There was a problem hiding this comment.
Pull Request Overview
This PR updates the border color values for the ui-view component so that the view colors are in sync with the design documentation.
- Updated primary border color from grey1214 to grey1424
- Updated secondary border color from grey4570 to grey3045
Comments suppressed due to low confidence (2)
packages/ui-view/src/View/theme.ts:65
- Please verify that the updated primary border color 'grey1424' exactly matches the design documentation specifications.
borderColorPrimary: colors?.contrasts?.grey1424,
packages/ui-view/src/View/theme.ts:66
- Confirm that the new secondary border color 'grey3045' is aligned with the design docs and applied consistently across the component.
borderColorSecondary: colors?.contrasts?.grey3045,
|
ToMESSKa
approved these changes
Apr 25, 2025
git-nandor
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TEST PLAN: check if the colors of View is in sync with the design docs
https://docs.google.com/spreadsheets/d/16_GjG_LvCvvvkdvFNTcrC11P81GwwSRyWGxKbc5RWeE/edit?gid=0#gid=0
INSTUI-4532