Attempt to fix 'JSON5: invalid end of input' build error in CI#1960
Merged
Attempt to fix 'JSON5: invalid end of input' build error in CI#1960
Conversation
|
The debug statements help to investigate flaky CI builds that fail with "JSON5: invalid end of input at 1:1" Also remove 'fse', since the erro seems to be that 'styleDictionarySource' is not created in some cases
18e8665 to
ac6f1e8
Compare
matyasf
commented
May 7, 2025
Comment on lines
-35
to
-36
| return fse | ||
| .outputFile(sourcePath, JSON.stringify(styleDictionarySource)) |
Collaborator
Author
There was a problem hiding this comment.
The error was likely that this was not created in some rare cases, I dont know why. I've replaced it with just native Node code
joyenjoyer
approved these changes
May 8, 2025
balzss
approved these changes
May 8, 2025
Contributor
balzss
left a comment
There was a problem hiding this comment.
I don't even know why a 3rd party lib was used in the first place. Good find!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The debug statements help to investigate flaky CI builds that fail.
Also remove
fse, since the error seems to be thatstyleDictionarySourceis not created in some casesTrying to fix errors like