Skip to content

docs(ui-select): fix_focus_input_function_in_select_examples#1961

Merged
ToMESSKa merged 1 commit intomasterfrom
INSTUI-4539_fix_focus_input_function_in_select_examples
May 9, 2025
Merged

docs(ui-select): fix_focus_input_function_in_select_examples#1961
ToMESSKa merged 1 commit intomasterfrom
INSTUI-4539_fix_focus_input_function_in_select_examples

Conversation

@ToMESSKa
Copy link
Contributor

@ToMESSKa ToMESSKa commented May 6, 2025

INSTUI-4539

IISSUE:

  • the line handling the input blur isn't in the right place
  • handling the inputRef with states is not a good practice

TEST PLAN:

  • check the class and functional examples on iPad/iPhone with VoiceOver, the focus should be returned to the input field after selecting an option
  • functional examples should handle inputRef with useRef

@github-actions
Copy link

github-actions bot commented May 6, 2025

PR Preview Action v1.6.1
Preview removed because the pull request was closed.
2025-05-09 07:06 UTC

@ToMESSKa ToMESSKa self-assigned this May 6, 2025
@ToMESSKa ToMESSKa requested review from HerrTopi and matyasf May 6, 2025 13:49
Copy link
Collaborator

@matyasf matyasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Copy link
Contributor

@HerrTopi HerrTopi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Works as expected, at least on iPhone

@ToMESSKa ToMESSKa merged commit 1f37855 into master May 9, 2025
10 checks passed
@ToMESSKa ToMESSKa deleted the INSTUI-4539_fix_focus_input_function_in_select_examples branch May 9, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants