Conversation
|
ToMESSKa
reviewed
May 7, 2025
| */ | ||
| variant?: 'info' | 'success' | 'warning' | 'error' | ||
| /** | ||
| * How the screen reader should announce the alert variant. While the `variant` prop sets the color and icon for the alert component, this label should be a textual representation of that information. So e.g. if the variant is `info`, this label could be "Information:" or "Information alert:". Note the `:` at the end of the label which helps the screenreader to be more natural sounding. |
Contributor
There was a problem hiding this comment.
@balzss JAWS unfortunately reads the ':' as 'colon', but I checked that ',' works as a pause with VoiceOver and JAWS too, so I would recommend that instead.
Contributor
There was a problem hiding this comment.
@balzss The text still says "Note the : at", so it might be good to change that too.
matyasf
requested changes
May 7, 2025
balzss
force-pushed
the
fix/alert-message-screenreader
branch
from
8317832 to
1ff0b9b
Compare
balzss
force-pushed
the
fix/alert-message-screenreader
branch
from
1ff0b9b to
3df0be3
Compare
matyasf
approved these changes
May 28, 2025
Collaborator
matyasf
left a comment
matyasf
left a comment
There was a problem hiding this comment.
looks good to me, just please update the docs to use ',' as Tamas mentioned
ToMESSKa
requested changes
May 28, 2025
Contributor
ToMESSKa
left a comment
ToMESSKa
left a comment
There was a problem hiding this comment.
see my comment in props.ts
… screenreader usability
balzss
force-pushed
the
fix/alert-message-screenreader
branch
from
3df0be3 to
8d36fef
Compare
ToMESSKa
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INSTUI-4533
test plan: