fix(many): fix access of colors from theme#1993
Merged
Conversation
INSTUI-4561
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the access of colors from the theme by adding additional optional chaining to prevent potential runtime errors when theme properties are missing.
- Updated SideNavBarItem theme to safely access contrast colors.
- Updated RadioInputGroup, Heading, and Avatar themes to consistently use optional chaining.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/ui-side-nav-bar/src/SideNavBar/SideNavBarItem/theme.ts | Ensure safe access to contrast colors for focus outlines. |
| packages/ui-radio-input/src/RadioInputGroup/theme.ts | Use optional chaining for invalid asterisk color access. |
| packages/ui-heading/src/Heading/theme.ts | Safely access gradient colors via optional chaining. |
| packages/ui-avatar/src/Avatar/theme.ts | Consistently use optional chaining for color property access. |
|
ToMESSKa
approved these changes
May 29, 2025
joyenjoyer
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INSTUI-4561