-
Notifications
You must be signed in to change notification settings - Fork 110
chore: upgrade jsdoc to latest to support node 23+ #2009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -59,15 +59,15 @@ const config = merge(baseConfig, { | |
| directory: outputPath, | ||
| }, | ||
| host: '0.0.0.0', | ||
| onListening: function () { | ||
| onListening: async function () { | ||
| // devServer is watching source files by default and hot reloading the docs page if they are changed | ||
| // however markdown files (i.e. README.md) need to be recompiled hence the need for chokidar | ||
| const paths = globbySync(['packages/**/*.md', 'docs/**/*.md'], { cwd: '../../' }).map(p => '../../' + p) | ||
| chokidar | ||
| .watch(paths) | ||
| .on('change', (evt) => { | ||
| .on('change', async (evt) => { | ||
| const fullPath = resolvePath(import.meta.dirname, evt) | ||
| processSingleFile(fullPath) | ||
| await processSingleFile(fullPath) | ||
|
Comment on lines
+62
to
+70
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Both the Webpack onListening https://webpack.js.org/configuration/dev-server/#devserveronlistening I think this should work fine for 99% of use cases (unless you somehow modify the same file in very quick succession?) but please put a comment to both functions, that these do not wait for the promise to return. |
||
| }) | ||
| }, | ||
| client: { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cant this be a dev dep?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or is this even needed?