fix(ui-buttons): remove underline from disabled Button with href

[ToMESSKa]

INSTUI-4540

ISSUE:

• BaseButton text has an underline when disabled and has a href prop

TEST PLAN:

• test the code below, the buttons' text should not have an underline

<div>
  <BaseButton disabled href='#'>Click me</BaseButton>
  <Button disabled href='#'>Click me</Button>
</div>

[Copilot]

Pull Request Overview

This PR ensures that disabled Button components rendered as links do not display an underline.

• Introduces an isEnabled flag to style logic
• Applies full button styles only when enabled, and sets textDecoration: 'none' when disabled
• Adds a test to verify that disabled links have no underline

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
packages/ui-buttons/src/BaseButton/styles.ts	Added isEnabled state and made baseButton styles conditional on that flag
packages/ui-buttons/src/BaseButton/props.ts	Extended BaseButtonStyleProps with a new isEnabled property
packages/ui-buttons/src/BaseButton/index.tsx	Removed conditional CSS prop and always applies styles.baseButton
packages/ui-buttons/src/BaseButton/new-tests/BaseButton.test.tsx	New test confirming disabled link Buttons have no underline

[github-actions]

PR Preview Action v1.6.1
Preview removed because the pull request was closed.
2025-06-13 10:10 UTC

[matyasf]

see my comment

[matyasf]

Please add here these:

          label: 'baseButton',
          appearance: 'none',

Label is needed, so it's easier to identity what this is in the DOM (also unit tests might use it), appearance: none might prevent some custom CSS to override things here (although I could not override it)

[ToMESSKa]

@matyasf I added them