fix(ui-buttons): disabled button with href should not receive focus#2110
Closed
joyenjoyer wants to merge 1 commit intomasterfrom
Closed
fix(ui-buttons): disabled button with href should not receive focus#2110joyenjoyer wants to merge 1 commit intomasterfrom
joyenjoyer wants to merge 1 commit intomasterfrom
Conversation
|
joyenjoyer
force-pushed
the
INSTUI-4687-disabled-button-should-not-receive-focus
branch
from
6938dca to
4af8687
Compare
joyenjoyer
force-pushed
the
INSTUI-4687-disabled-button-should-not-receive-focus
branch
from
4af8687 to
481ae40
Compare
git-nandor
approved these changes
Sep 9, 2025
ToMESSKa
requested changes
Sep 9, 2025
Contributor
There was a problem hiding this comment.
@joyenjoyer In Safari (Version 18.6 (20621.3.11.11.3)), Button is still focusable (it has a focus ring) when disabled with a href. Can you please check this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INSTUI-4687
Test: