Skip to content

fix(ui-table): make TableColHeader focus outline and sorted icon over… #2142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ToMESSKa merged 1 commit into from
Sep 25, 2025
Merged

fix(ui-table): make TableColHeader focus outline and sorted icon over… #2142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions packages/ui-table/src/Table/ColHeader/theme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
* SOFTWARE.
*/

import type { Theme } from '@instructure/ui-themes'
import type { Theme, ThemeSpecificStyle } from '@instructure/ui-themes'
import { TableColHeaderTheme } from '@instructure/shared-types'

/**
Expand All @@ -31,7 +31,14 @@ import { TableColHeaderTheme } from '@instructure/shared-types'
* @return {Object} The final theme object with the overrides and component variables
*/
const generateComponentTheme = (theme: Theme): TableColHeaderTheme => {
const { typography, colors, borders, spacing } = theme
const { typography, colors, borders, spacing, key: themeName } = theme

const themeSpecificStyle: ThemeSpecificStyle<TableColHeaderTheme> = {
canvas: {
focusOutlineColor: theme['ic-brand-primary'],
sortedIconColor: theme['ic-brand-primary']
}
}

const componentVariables: TableColHeaderTheme = {
fontSize: typography?.fontSizeMedium,
Expand All @@ -54,7 +61,8 @@ const generateComponentTheme = (theme: Theme): TableColHeaderTheme => {
}

return {
...componentVariables
...componentVariables,
...themeSpecificStyle[themeName]
}
}

Expand Down
Loading