Skip to content

[v12] feat(ui-pill): Pill rework #2293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
git-nandor merged 1 commit into from
Dec 16, 2025
Merged

[v12] feat(ui-pill): Pill rework #2293

git-nandor merged 1 commit into from
Dec 16, 2025
+37 −125

Conversation

@git-nandor
Copy link
Contributor

@git-nandor git-nandor commented Dec 5, 2025

INSTUI-4800

Summary

Migrated Pill component from the old theming system.

Test plan

On the documentation page, verify that everything displays and works correctly.

Co-Authored-By: 🤖 Claude

@git-nandor git-nandor self-assigned this Dec 5, 2025
@git-nandor git-nandor changed the base branch from master to v12 December 5, 2025 14:47
@git-nandor git-nandor force-pushed the INSTUI-4800_pill_rework branch from 1abeb41 to a02b805 Compare December 5, 2025 14:50
@git-nandor git-nandor marked this pull request as ready for review December 5, 2025 14:51
@github-actions
Copy link

github-actions bot commented Dec 5, 2025 •
edited
Loading

PR Preview Action v1.6.3
Preview removed because the pull request was closed.
2025-12-16 14:04 UTC

@git-nandor git-nandor force-pushed the INSTUI-4800_pill_rework branch from a02b805 to ae51213 Compare December 5, 2025 16:24
matyasf
matyasf requested changes Dec 11, 2025
View reviewed changes
Copy link
Collaborator

@matyasf matyasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example in the docs page is weird, it shows all the themes. Please rewrite it, so it only shows the current theme.

adamlobler
adamlobler requested changes Dec 13, 2025
View reviewed changes
Copy link
Collaborator

@adamlobler adamlobler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the showcase as well. Right now, it’s using the legacy icons, but we should use the new Lucide icons instead.
Also, we should only show the components in one theme, just like the other showcases.

@git-nandor git-nandor force-pushed the INSTUI-4800_pill_rework branch from ae51213 to e9d0948 Compare December 15, 2025 10:38
@git-nandor
Copy link
Contributor Author

git-nandor commented Dec 15, 2025

We should update the showcase as well. Right now, it’s using the legacy icons, but we should use the new Lucide icons instead. Also, we should only show the components in one theme, just like the other showcases.

New Lucide icons have been added, and I removed the theme variants, so now they are rendered according to the currently selected theme only.

@git-nandor git-nandor force-pushed the INSTUI-4800_pill_rework branch from e9d0948 to 003931b Compare December 15, 2025 11:25
matyasf
matyasf approved these changes Dec 16, 2025
View reviewed changes
Copy link
Collaborator

@matyasf matyasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@git-nandor git-nandor merged commit 61f1f9c into v12 Dec 16, 2025
6 of 7 checks passed
@git-nandor git-nandor deleted the INSTUI-4800_pill_rework branch December 16, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matyasf matyasf matyasf approved these changes

@adamlobler adamlobler adamlobler approved these changes

@ToMESSKa ToMESSKa ToMESSKa approved these changes

@hajnaldo hajnaldo Awaiting requested review from hajnaldo

Assignees

@git-nandor git-nandor

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@git-nandor @matyasf @adamlobler @ToMESSKa