spread canvas.typography #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves theme configuration by properly spreading the canvas typography object before overriding the fontFamily property, ensuring that existing typography settings from the canvas theme are preserved rather than being replaced entirely.
Key Changes:
- Spread
canvas.typographyproperties before setting customfontFamilyto preserve existing typography configuration - Move font CSS import from
App.tsxtoMain.tsxfor better organization of global styles
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/roadmap/src/App.tsx | Updated theme configuration to spread canvas.typography properties and removed font import |
| apps/roadmap/src/Main.tsx | Added font CSS import at the application entry point |
| apps/roadmap/src/assets/fonts/AtkinsonHyperlegibleNext.css | Formatting fix (added trailing newline) |
| apps/roadmap/package.json | Code formatting update (spaces to tabs) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.