-
Notifications
You must be signed in to change notification settings - Fork 1
Shared configs/vite plus #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request refactors the shared configurations and build tooling across the monorepo, transitioning from Vite/Biome to TSDown/OxC and reorganizing configuration files for better maintainability. Key changes include removing legacy build configurations, updating linting/formatting tools, consolidating object literal formatting, and removing deprecated .tsx component files in favor of .ts files.
- Removes legacy Vite ESM build config and TypeScript build config
- Replaces Biome with OxC for linting and formatting
- Consolidates inline object literals to single-line format in generated component files
- Updates test assertions from
.toBe()to.toBeTruthy()/.toBeFalsy()and.toEqual()to.toStrictEqual()
Reviewed changes
Copilot reviewed 170 out of 209 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| vitest.config.shared.mts | Reorganizes coverage configuration properties for consistency |
| vitest.config.mts | Reorders test and coverage include patterns |
| vite.config.mts | Refactors package name/version handling and improves variable naming |
| vite.config.esm.mts | Removes legacy ESM build configuration file |
| tsconfig.build.json | Removes legacy TypeScript build configuration |
| tests/branch-naming-regex.test.ts | Updates test assertions to use .toBeTruthy()/.toBeFalsy() |
| scripts/workspace.mts | Adds function overloads, improves error handling, and refactors command validation |
| scripts/test.mts | Reorders imports and refactors command validation logic |
| scripts/release.mts | Improves conditional formatting and command validation |
| scripts/preview.mts | Adds type guards and function overloads for better type safety |
| scripts/new.mts | Adds braces to single-statement conditionals for consistency |
| scripts/lint.mts | Updates lint command and refactors validation logic |
| scripts/issues.mts | Replaces .sort() with .toSorted() for immutability |
| scripts/info.test.mts | Improves mock type safety with explicit typing |
| scripts/info.mts | Updates error variable naming from e to error |
| scripts/dev.mts | Adds type guards and refactors command validation |
| scripts/build.mts | Adds type guards and improves null handling |
| plugins/vitest.plugin.coverageReporter.cjs | Updates quotes, null handling, and sorting methods |
| plugins/vite.plugin.multiPreview.mts | Updates quotes and adds early returns |
| plugins/vite-node.plugin.loader.test.js | Updates test assertions and improves formatting |
| packages/aiinfo/vite.config.mts | Removes entire file (legacy build config) |
| packages/aiinfo/utils/* | Updates error handling, type definitions, and object literal formatting |
| packages/aiinfo/types.ts | Converts type aliases to interfaces |
| packages/aiinfo/tsdown.config.mts | Adds new TSDown build configuration |
| packages/aiinfo/tests/* | Updates test assertions and test descriptions |
| packages/aiinfo/strings/* | Replaces Biome ignore comments with OxC equivalents |
| packages/aiinfo/src/* | Adds new declaration files for ESM/CJS formats |
| packages/aiinfo/scripts/* | Updates error handling and formatting commands |
| packages/aiinfo/package.json | Updates build scripts and version number |
| packages/aiinfo/node/components/* | Removes .tsx files and consolidates object literals in .ts files |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Uh oh!
There was an error while loading. Please reload this page.