Conversation
Remove dark mode detection and styling so the roadmap app always renders in light mode regardless of the user's system preference. - Remove prefers-color-scheme dark media query from themeEditor.css - Replace isDark useState with constant false in App.tsx
There was a problem hiding this comment.
Pull request overview
This PR removes dark mode support from the roadmap application by eliminating the dynamic detection of user color scheme preferences and hardcoding the light mode theme.
Key Changes:
- Replaced dynamic dark mode state management with a hardcoded
falsevalue - Removed all dark mode CSS variables and media queries from the theme editor
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/roadmap/src/App.tsx | Removed dark mode detection logic using matchMedia and replaced stateful isDark with a constant set to false |
| apps/roadmap/public/themeEditor.css | Removed the entire dark mode media query block containing CSS custom properties for dark theme styling |
|
|
||
| return () => mediaQuery.removeEventListener("change", handler); | ||
| }, []); | ||
| const isDark = false; |
There was a problem hiding this comment.
The isDark constant is now hardcoded to false, but it's still being passed to the Card, CardOverlay, and Loading components (lines 103, 113, and 120). Since dark mode support is being removed, consider removing the isDark prop from these components entirely and simplifying their implementations to only support light mode. This would eliminate dead code and reduce unnecessary conditional logic throughout the application.
1 participant
Summary