fix: include oidc-auth-request-extra-params in token cache key#1497
Open
cnuss wants to merge 1 commit intoint128:masterfrom
Open
fix: include oidc-auth-request-extra-params in token cache key#1497cnuss wants to merge 1 commit intoint128:masterfrom
cnuss wants to merge 1 commit intoint128:masterfrom
Conversation
The token cache key computation did not include the AuthRequestExtraParams values from the --oidc-auth-request-extra-params flag. This caused tokens with different extra parameters (e.g., different audience values) to incorrectly share the same cache entry. Changes: - Add AuthRequestExtraParams field to tokencache.Key struct - Add AuthRequestExtraParams() method to GrantOptionSet to extract extra params from whichever grant option is set - Update get_token.go to include extra params in cache key - Add comprehensive tests for cache key differentiation Fixes int128#1496
Author
|
@int128 Would appreciate your review when you have a chance. This fixes a cache collision issue when using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--oidc-auth-request-extra-paramswith different valuesAuthRequestExtraParamsfield totokencache.KeystructAuthRequestExtraParams()method onGrantOptionSetProblem
The token cache key computation did not include the
AuthRequestExtraParamsvalues from the--oidc-auth-request-extra-paramsflag. This caused tokens with different extra parameters (e.g., differentaudiencevalues) to incorrectly share the same cache entry.For example:
Both commands would use the same cache key, causing the second call to return the token from the first call, even though they requested tokens for different audiences.
Test plan
AuthRequestExtraParamsproduce different cache checksumsGrantOptionSet.AuthRequestExtraParams()methodgo vetpassesFixes #1496