Fix various name resolution failures in DelphiSymbolTableExecutorTest

These failures weren't important to the tests, but it's best for this
code to be as well-formed as possible. Plus, it helped in identifying
cases where we were logging name resolution failures erroneously.

Author: cirras

delphi-frontend/src/test/java/au/com/integradev/delphi/executor/DelphiSymbolTableExecutorTest.java

@@ -325,8 +325,8 @@ void testSelfTypes() {
   @Test
   void testSelfInNestedProcedures() {
     execute("SelfInNestedProcedures.pas");
-    verifyUsages(17, 11, reference(34, 2));
-    verifyUsages(19, 11, reference(29, 4), reference(38, 4));
+    verifyUsages(17, 11, reference(37, 2));
+    verifyUsages(19, 11, reference(32, 4), reference(41, 4));
   }
 
   @Test
@@ -499,8 +499,8 @@ void testSimpleTypeResolution() {
   @Test
   void testCharTypeResolution() {
     execute("typeResolution/Chars.pas");
-    verifyUsages(7, 9, reference(22, 2));
-    verifyUsages(12, 9, reference(23, 2));
+    verifyUsages(7, 10, reference(22, 2));
+    verifyUsages(12, 10, reference(23, 2));
   }
 
   @Test
@@ -1073,10 +1073,10 @@ void testGenericParameterizedMethods() {
         11,
         14,
         reference(16, 15),
-        reference(29, 2),
-        reference(30, 2),
-        reference(31, 2),
-        reference(32, 2));
+        reference(23, 2),
+        reference(24, 2),
+        reference(25, 2),
+        reference(26, 2));
   }
 
   @Test
@@ -1606,15 +1606,21 @@ private static Path createStandardLibrary(Path baseDir) {
           "unit System;\n"
               + "interface\n"
               + "type\n"
+              + "  TArray<T> = array of T;\n"
               + "  TObject = class\n"
-              + "    constructor Create;"
+              + "    constructor Create;\n"
+              + "    procedure Free;\n"
               + "  end;\n"
               + "  IInterface = interface\n"
               + "  end;\n"
-              + "  TClassHelperBase = class\n"
+              + "  TInterfacedObject = class(TObject, IInterface)\n"
+              + "  end;\n"
+              + "  TClassHelperBase = class(TInterfacedObject, IInterface)\n"
               + "  end;\n"
               + "  TVarRec = record\n"
               + "  end;\n"
+              + "  TCustomAttribute = class(TObject)\n"
+              + "  end;\n"
               + "implementation\n"
               + "end.");
 
@@ -1716,7 +1722,7 @@ private static Path createStandardLibrary(Path baseDir) {
               + "function MessageDlg(const Msg: string; DlgType: TMsgDlgType;\n"
               + "  Buttons: TMsgDlgButtons; HelpCtx: Longint): Integer;\n"
               + "begin\n"
-              + "  Result := MessageDlgPosHelp(Msg, DlgType, Buttons, HelpCtx, -1, -1, '');\n"
+              + "  // ...\n"
               + "end;\n"
               + "\n"
               + "end.");

delphi-frontend/src/test/resources/au/com/integradev/delphi/symbol/BareInterfaceMethodReference.pas

@@ -3,7 +3,7 @@
 interface
 
 function Foo(Baz: Integer): Integer;
-function ExternalFunc(Result: Booelan): Boolean;
+function ExternalFunc(Result: Boolean): Boolean;
 
 implementation
 

delphi-frontend/src/test/resources/au/com/integradev/delphi/symbol/BestEffortArguments.pas

@@ -8,7 +8,7 @@ procedure Foo;
 var
   Bar: Integer;
 begin
-  Baz(Bar)[Bar];
+  Baz(Bar)[Bar]; // The Baz invocation does not resolve, but the Bar expressions still should.
 end;
 
 end.

delphi-frontend/src/test/resources/au/com/integradev/delphi/symbol/SelfInNestedProcedures.pas

@@ -22,6 +22,9 @@ implementation
 
 uses System.SysUtils;
 
+type
+  TProc<T> = reference to procedure(Arg: T);
+
 procedure TFoo.MyProc;
 
   procedure SubProc(Self: TBaz);

delphi-frontend/src/test/resources/au/com/integradev/delphi/symbol/classReferences/ArgumentResolution.pas

@@ -15,15 +15,15 @@   TMetaFoo = class of TFoo;
 
 implementation
 
-procedure CallBaz(Meta: TMetaFoo);
+procedure AcceptFooType(Meta: TMetaFoo);
 begin
-  Baz.Baz;
+  // ...
 end;
 
 procedure Test;
 begin
-  CallBaz(TFoo);
-  CallBaz(TBar);
+  AcceptFooType(TFoo);
+  AcceptFooType(TBar);
 end;
 
 

delphi-frontend/src/test/resources/au/com/integradev/delphi/symbol/dependencies/Helper.pas

@@ -7,12 +7,7 @@ implementation
 uses
   System.SysUtils;
 
-function Foo: Boolean;
-begin
-  Result := HelperDependency.Bar.NONEXISTENT;
-end;
-
-function Bar: Boolean;
+function IsStringEmpty: Boolean;
 begin
   Result := ''.IsEmpty;
 end;

delphi-frontend/src/test/resources/au/com/integradev/delphi/symbol/dependencies/imports/UnitWithGetEnumeratorForTObject.pas

@@ -6,7 +6,7 @@ interface
   TObjectHelper = class helper for TObject
     function GetEnumerator: TObject;
     function MoveNext: Boolean;
-    property Current: TObject read Foo;
+    property Current: TObject;
   end;
 
 implementation

delphi-frontend/src/test/resources/au/com/integradev/delphi/symbol/generics/ParameterizedMethod.pas

@@ -14,14 +14,8 @@   TFoo = class
 implementation
 
 procedure TFoo.CompareAndPrintResult<T>(X, Y: T);
-var
-  Comparer : IComparer<T>;
 begin
-  Comparer := TComparer<T>.Default;
-  if Comparer.Compare(X, Y) = 0 then
-    WriteLn('Both members compare as equal')
-  else
-    WriteLn('Members do not compare as equal');
+  // ...
 end;
 
 procedure TFoo.Test;

delphi-frontend/src/test/resources/au/com/integradev/delphi/symbol/operators/UnaryOperatorOverloads.pas

@@ -19,14 +19,14 @@ implementation
   Result := True;
 end;
 
-class operator TFoo.Positive(Foo: TFoo): String;
+class operator TFoo.Positive(Foo: TFoo): Integer;
 begin
-  Result := '';
+  Result := 123;
 end;
 
-class operator TFoo.Negative(Foo: TFoo): Integer;
+class operator TFoo.Negative(Foo: TFoo): String;
 begin
-  Result := 123;
+  Result := '';
 end;
 
 procedure ExpectBoolean(Bool: Boolean);

delphi-frontend/src/test/resources/au/com/integradev/delphi/symbol/overloads/CharInSet.pas

@@ -10,7 +10,7 @@   TFoo = class(TObject)
   protected
     FChar: Char;
   public
-    property CharProperty: Char read FToken;
+    property CharProperty: Char read FChar;
     function Test(TokenChar: TCharSet): Boolean;
   end;