Prevent name resolution failure logging on implementation-local routines

Author: cirras

delphi-frontend/src/main/java/au/com/integradev/delphi/symbol/resolve/NameResolutionHelper.java

@@ -339,6 +339,13 @@ public void resolve(RoutineImplementationNode routine) {
     }
 
     resolver.disambiguateIsClassInvocable(routine.isClassMethod());
+
+    if (resolver.nameResolutionFailed() && !routine.getNameReferenceNode().isQualified()) {
+      // No interface declaration found, and not a qualified name so it can't be a method.
+      // It must be an implementation-local routine.
+      return;
+    }
+
     resolver.addToSymbolTable();
 
     completeTypeParameterReferences(routine);

delphi-frontend/src/main/java/au/com/integradev/delphi/symbol/resolve/NameResolver.java

@@ -203,6 +203,10 @@ public boolean isAmbiguous() {
     return declarations.size() > 1;
   }
 
+  public boolean nameResolutionFailed() {
+    return names.size() != resolvedDeclarations.size() + Math.min(1, declarations.size());
+  }
+
   private void checkAmbiguity() {
     if (isAmbiguous()) {
       if (LOG.isWarnEnabled()) {
@@ -664,10 +668,6 @@ private NameOccurrence createNameOccurrence(NameReferenceNode reference, boolean
     return occurrence;
   }
 
-  private boolean nameResolutionFailed() {
-    return names.size() != resolvedDeclarations.size() + Math.min(1, declarations.size());
-  }
-
   private void specializeDeclarations(NameOccurrence occurrence) {
     declarations =
         declarations.stream()