Handle aliases when casting to *TypeImpl classes

This is a little bit of a "gotcha".

Now that type aliases are transparent to the aliased type, we need to do
a little extra work before internally casting a type to `Impl` for
mutable operations.

Otherwise, you might try to cast a generated alias implementation to
some unrelated type.

Author: cirras

delphi-frontend/src/main/java/au/com/integradev/delphi/antlr/ast/visitors/SymbolTableVisitor.java

@@ -759,7 +759,7 @@ private Data createTypeScope(TypeDeclarationNode node, Data data) {
     Type type = declaration.getType();
     typeScope.setType(type);
 
-    if (!node.isWeakAlias()
+    if (!type.isAlias()
         && type.isPointer()
         && data.switchRegistry.isActiveSwitch(SwitchKind.POINTERMATH, node.getTokenIndex())) {
       ((PointerTypeImpl) type).setAllowsPointerMath();

delphi-frontend/src/main/java/au/com/integradev/delphi/symbol/resolve/NameResolutionHelper.java

@@ -74,6 +74,7 @@
 import org.sonar.plugins.communitydelphi.api.symbol.scope.DelphiScope;
 import org.sonar.plugins.communitydelphi.api.symbol.scope.RoutineScope;
 import org.sonar.plugins.communitydelphi.api.type.Type;
+import org.sonar.plugins.communitydelphi.api.type.Type.AliasType;
 import org.sonar.plugins.communitydelphi.api.type.Type.ProceduralType;
 import org.sonar.plugins.communitydelphi.api.type.Type.ScopedType;
 import org.sonar.plugins.communitydelphi.api.type.Type.TypeParameterType;
@@ -517,7 +518,12 @@ private static void completeTypeParameterReferences(RoutineImplementationNode ro
 
       TypeParameterType parameterType = (TypeParameterType) parameterDeclaration.getType();
       Type argumentType = parameterReference.getType();
-      if (argumentType.isTypeParameter()) {
+
+      while (argumentType.isWeakAlias()) {
+        argumentType = ((AliasType) argumentType).aliasedType();
+      }
+
+      if (!argumentType.isAlias() && argumentType.isTypeParameter()) {
         ((TypeParameterTypeImpl) argumentType).setFullType(parameterType);
       }
     }