Implement multiline strings #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fourls
requested changes
Feb 29, 2024
Collaborator
fourls
left a comment
fourls
left a comment
There was a problem hiding this comment.
Looks good on the whole, just some comments on the changelog and minor code thoughts.
delphi-frontend/src/main/antlr3/au/com/integradev/delphi/antlr/Delphi.g
Outdated
Show resolved
Hide resolved
delphi-frontend/src/main/antlr3/au/com/integradev/delphi/antlr/Delphi.g
Outdated
Show resolved
Hide resolved
...-frontend/src/test/java/au/com/integradev/delphi/antlr/ast/node/TextLiteralNodeImplTest.java
Show resolved
Hide resolved
delphi-frontend/src/main/java/au/com/integradev/delphi/antlr/ast/node/TextLiteralNodeImpl.java
Show resolved
Hide resolved
delphi-frontend/src/main/java/au/com/integradev/delphi/antlr/ast/node/TextLiteralNodeImpl.java
Show resolved
Hide resolved
cirras
force-pushed
the
multiline-string
branch
from
3e68807 to
2b539c3
Compare
Deprecated in favor of `getValue`, which is a more appropriate name for what this does. Also, `getImage` returns the raw image instead of partially evaluating it and leaving the quotes on (which didn't make much sense).
- Add support for binary literals - Add support for digit separators
fourls
approved these changes
Mar 1, 2024
Collaborator
fourls
left a comment
fourls
left a comment
There was a problem hiding this comment.
Looks good! This is an important milestone for D12 support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
getImageWithoutQuotesin favor ofgetValueTextLiteralNodeImplCloses #80.