-
Notifications
You must be signed in to change notification settings - Fork 27
Full support for Delphi 12 #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fourls
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay in reviewing - looks great for the most part! Just a couple of questions and a changelog improvement.
There's been a few changes in master since this branch forked, so would be good to get it rebased on master as well.
delphi-frontend/src/main/java/au/com/integradev/delphi/type/intrinsic/IntrinsicReturnType.java
Show resolved
Hide resolved
|
Code change looks good, but it seems to have significantly increased the execution time of the Initial analysis and profiling suggests that it's due to an uptick in the volume of runtime classes generated for weak alias types. |
This was because we started generating weak aliases as part of |
fourls
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good now! Tests are back down to usual durations (perhaps even slightly faster).
Looks like we can close the book on Delphi 12 compatibility now 😄
This PR finishes implementing support for Delphi 12.