Create rule FullyQualifiedImportCheck #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EduardoVaz06
force-pushed
the
ImportsShouldBeFullyQualified
branch
from
8ca49b4 to
2927b16
Compare
fourls
previously requested changes
Aug 22, 2024
There was a problem hiding this comment.
Hi @EduardoVaz06, thanks for this contribution! Looks great and will be a useful rule for codebases looking to gradually transition to fully qualified imports.
I've made a few comments below, nothing major. Also note that the failing CI is just complaining about the rule having no tags.
...ks/src/main/resources/org/sonar/l10n/delphi/rules/community-delphi/FullyQualifiedImport.json
Outdated
Show resolved
Hide resolved
...ks/src/main/resources/org/sonar/l10n/delphi/rules/community-delphi/FullyQualifiedImport.html
Outdated
Show resolved
Hide resolved
...ks/src/main/resources/org/sonar/l10n/delphi/rules/community-delphi/FullyQualifiedImport.html
Outdated
Show resolved
Hide resolved
delphi-checks/src/main/java/au/com/integradev/delphi/checks/FullyQualifiedImportCheck.java
Outdated
Show resolved
Hide resolved
delphi-checks/src/main/java/au/com/integradev/delphi/checks/FullyQualifiedImportCheck.java
Outdated
Show resolved
Hide resolved
...ks/src/main/resources/org/sonar/l10n/delphi/rules/community-delphi/FullyQualifiedImport.json
Outdated
Show resolved
Hide resolved
delphi-checks/src/main/java/au/com/integradev/delphi/checks/FullyQualifiedImportCheck.java
Outdated
Show resolved
Hide resolved
EduardoVaz06
force-pushed
the
ImportsShouldBeFullyQualified
branch
from
2927b16 to
19c49d7
Compare
3 tasks
EduardoVaz06
force-pushed
the
ImportsShouldBeFullyQualified
branch
2 times, most recently
from
26e5564 to
61f276e
Compare
cirras
requested changes
Sep 25, 2024
...ks/src/main/resources/org/sonar/l10n/delphi/rules/community-delphi/FullyQualifiedImport.html
Show resolved
Hide resolved
EduardoVaz06
force-pushed
the
ImportsShouldBeFullyQualified
branch
from
61f276e to
0a252ea
Compare
cirras
approved these changes
Sep 25, 2024
cirras
dismissed
fourls’s stale review
Feedback addressed, and I've finished reviewing the contribution.
cirras
merged commit 3143498
into
integrated-application-development:master
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new rule: FullyQualifiedImportCheck.
As sugested in #62, this rule simply checks if the imports in the UsesClausesNode are fully qualified. If they are not, an issue is raised, suggesting to change it to be fully qualified.