Skip to content

Conversation

@jgardn3r
Copy link
Collaborator

It is common for a test name not to represent what it is asserting. An example of this is a test named ...ShouldAddIssue calling verifyNoIssues.

This PR adds some architecture tests targeting checks that assert:

  • Test names are accurate to the assertion
  • All checks have test units
  • All test units have an associated check

@jgardn3r jgardn3r requested a review from cirras September 30, 2024 04:22
Copy link
Collaborator

@cirras cirras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tweaks.
Most of them are just removing FalsePositive from test names.

Copy link
Collaborator

@cirras cirras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 🎉

@cirras cirras merged commit 2ec51a3 into master Oct 4, 2024
2 checks passed
@cirras cirras deleted the testArchTests branch October 4, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants