Skip to content

Conversation

@cirras
Copy link
Collaborator

@cirras cirras commented Dec 10, 2024

@spiltcoffee, a replacement for the automatic dependency submission.

The automatic dependency submission always fails on release commits because the new versions for delphi-tokens-generator-maven-plugin and license-maven-plugin are unavailable until they've been published.

This new workflow installs everything locally before running the dependency submission.

@cirras cirras requested a review from spiltcoffee December 10, 2024 02:56
Copy link

@spiltcoffee spiltcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, otherwise looking good

The automatic dependency submission always fails on release commits
because the new versions for `delphi-tokens-generator-maven-plugin` and
`license-maven-plugin` are unavailable until they've been published.

This new workflow installs everything locally before running the
dependency submission.
Copy link

@spiltcoffee spiltcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@cirras cirras merged commit 0eec50a into master Dec 10, 2024
3 checks passed
@cirras cirras deleted the scan-dependencies branch December 10, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants