Fix case-sensitive treatment of file names in coverage reports #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cirras
commented
Dec 12, 2024
delphi-frontend/src/main/java/au/com/integradev/delphi/msbuild/DelphiProjectHelper.java
Outdated
Show resolved
Hide resolved
cirras
force-pushed
the
mismatched_filenames_in_coverage_reports
branch
from
070e3c6 to
5e0bdbb
Compare
fourls
requested changes
Dec 12, 2024
Collaborator
fourls
left a comment
fourls
left a comment
There was a problem hiding this comment.
Does the trick on Windows - I have a couple of ideas about possible improvements.
delphi-frontend/src/main/java/au/com/integradev/delphi/coverage/DelphiCodeCoverageParser.java
Outdated
Show resolved
Hide resolved
...a/au/com/integradev/delphi/coverage/delphicodecoveragetool/DelphiCoverageToolParserTest.java
Outdated
Show resolved
Hide resolved
cirras
force-pushed
the
mismatched_filenames_in_coverage_reports
branch
2 times, most recently
from
2719a1d to
3b9a4ba
Compare
fourls
requested changes
Dec 17, 2024
Collaborator
fourls
left a comment
fourls
left a comment
There was a problem hiding this comment.
Looks good - just needs a changelog update.
File names are now treated as case-insensitive on windows.
cirras
force-pushed
the
mismatched_filenames_in_coverage_reports
branch
from
3b9a4ba to
42baf36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File names in coverage reports are now treated as case-insensitive on windows.
Fixes #325.