Reprioritize the analysis search path #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cirras
force-pushed
the
search-path-priority
branch
from
975c98e to
f7ce4ed
Compare
This change enables behaviors like: - shadowing standard library units with a unit on `DCC_UnitSearchPath` - shadowing `DCC_UnitSearchPath` units with a `DCCReference` unit These cases are somewhat unusual, but they are possible in Delphi.
cirras
force-pushed
the
search-path-priority
branch
from
f7ce4ed to
075807c
Compare
fourls
reviewed
Jan 17, 2025
Collaborator
fourls
left a comment
fourls
left a comment
There was a problem hiding this comment.
Looks good! Just have a couple of questions.
delphi-frontend/src/main/java/au/com/integradev/delphi/symbol/SymbolTableBuilder.java
Show resolved
Hide resolved
delphi-frontend/src/main/java/au/com/integradev/delphi/msbuild/DelphiProjectParser.java
Show resolved
Hide resolved
cirras
force-pushed
the
search-path-priority
branch
from
075807c to
094b175
Compare
cirras
force-pushed
the
search-path-priority
branch
2 times, most recently
from
29243ea to
1dbe3a8
Compare
fourls
requested changes
Jan 19, 2025
Collaborator
fourls
left a comment
fourls
left a comment
There was a problem hiding this comment.
Looks good, just one nitpick.
delphi-frontend/src/main/java/au/com/integradev/delphi/msbuild/DelphiProjectParser.java
Outdated
Show resolved
Hide resolved
cirras
force-pushed
the
search-path-priority
branch
from
1dbe3a8 to
7229927
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the browsing path in the search path, makes changes to the order of paths during
SearchPathcreation, and changes up the order of the unit data processing in theSymbolTableBuilder.The new search path priority is (highest to lowest):
sonar.sourcesDCCReferenceDCC_UnitSearchPathDebugger_DebugSourcePathDelphiLibraryPathDelphiTranslatedLibraryPathDelphiBrowsingPathThis change enables behaviors like:
DCC_UnitSearchPathDCC_UnitSearchPathunits with aDCCReferenceunitThese cases are somewhat unusual, but they are possible in Delphi.