Handle empty anonymous methods in EmptyRoutine instead of EmptyBlock
#331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fourls
requested changes
Jan 21, 2025
Collaborator
fourls
left a comment
fourls
left a comment
There was a problem hiding this comment.
Looks pretty good! I have a couple of comments.
delphi-checks/src/main/java/au/com/integradev/delphi/checks/EmptyRoutineCheck.java
Outdated
Show resolved
Hide resolved
...hi-frontend/src/main/java/org/sonar/plugins/communitydelphi/api/ast/AnonymousMethodNode.java
Show resolved
Hide resolved
cirras
force-pushed
the
empty_anonymous_method
branch
from
ac46997 to
20d1fd4
Compare
fourls
requested changes
Jan 21, 2025
Collaborator
fourls
left a comment
fourls
left a comment
There was a problem hiding this comment.
Just one note. Looks good otherwise.
delphi-checks/src/main/java/au/com/integradev/delphi/checks/EmptyRoutineCheck.java
Outdated
Show resolved
Hide resolved
cirras
force-pushed
the
empty_anonymous_method
branch
from
20d1fd4 to
a750db2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR excludes anonymous methods from
EmptyBlockand flags them inEmptyRoutineinstead.Fixes #315.