Skip to content

Conversation

@cirras
Copy link
Collaborator

@cirras cirras commented Feb 4, 2025

The previous approach (where sonar.sources took first priority in the analysis search path) caused some surprising/undesirable behavior in projects where there are multiple units with the same name.

It becomes very hard in that scenario for a user to configure the scan in a way where the correct unit will win during import resolution, even if the search path was correct in the dproj file.

The previous approach (where `sonar.sources` took first priority in the
analysis search path) caused some surprising/undesirable behavior in
projects where there are multiple units with the same name.

It becomes very hard in that scenario for a user to configure the scan
in a way where the correct unit will win during import resolution, even
if the search path was correct in the dproj file.
@cirras cirras requested a review from fourls February 4, 2025 22:43
Copy link
Collaborator

@fourls fourls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cirras cirras merged commit 514ddc6 into master Feb 4, 2025
4 checks passed
@cirras cirras deleted the sonar_sources_priority branch February 4, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants