Fix "tokens out of order" CPD errors around >= and <= tokens
#342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Token combination now creates a new token instead of mutating the last token in the group of combined tokens. This was causing problems because the combined token would be reflected back to the original list of "raw tokens" returned by `DelphiFile::getTokens`, resulting in overlapping tokens being reported to the sonar API. The mutability of the raw tokens is a point of brittleness that we could address, but it would have significant performance implications because it would involve constructing a copy of every token in every file.
Collaborator
|
Stretching my terminal window to its limits... |
fourls
approved these changes
Mar 5, 2025
Collaborator
fourls
left a comment
fourls
left a comment
There was a problem hiding this comment.
Looks good! Confirmed that this fixes the errors and that a test scan looks back to normal.
fourls
deleted the
when_i_was_a_child_a_gte_token_broke_into_my_house_and_stole_my_gameboy_and_i_have_held_a_grudge_ever_since
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Token combination now creates a new token instead of mutating the last token in the group of combined tokens.
This was causing problems because the combined token would be reflected back to the original list of "raw tokens" returned by
DelphiFile::getTokens, resulting in overlapping tokens being reported to the sonar API.The mutability of the raw tokens is a point of brittleness that we could address, but it would have significant performance implications because it would involve constructing a copy of every token in every file.