Exclude types annotated with attributes in UnusedType
#348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cirras
force-pushed
the
unused_type_attributes
branch
from
06e25f1 to
67988e6
Compare
cirras
force-pushed
the
unused_type_attributes
branch
from
67988e6 to
7c354ba
Compare
fourls
approved these changes
Mar 27, 2025
Collaborator
fourls
left a comment
fourls
left a comment
There was a problem hiding this comment.
Looks good! This will definitely improve the experience for RTTI-heavy projects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an exclusion to
UnusedTypefor types that are annotated with custom attributes.It's unclear why this wasn't already the case, as the same exclusion is already present in
UnusedRoutine,UnusedProperty, andUnusedField.