Define the WEAK_NATIVEINT conditional on Delphi 12+
#351
+15
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cirras
force-pushed
the
weak_nativeint_symbol
branch
from
ca1ff6a to
0e177f6
Compare
fourls
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the undocumented
WEAK_NATIVEINTpredefined conditional symbol.It's defined from Delphi 12 onward.
This was discovered due to a strange false positive on Delphi 12:
It turns out that the Delphi 12 RTL still declares
TNativeIntHelperand gates it behind thisWEAK_NATIVEINTsymbol.Without the symbol defined, the analyzer would see the
TNativeIntHelperrecord helper defined and overridingTIntegerHelpersince (as weak aliases) they are the same type now.This caused the analyzer to think that
TNativeIntHelper.Parsewas being called, which (of course) returns aNativeIntand confuses thePlatformDependentTruncationcheck.