Improve reporting of preprocessor-related parsing failures #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fourls
requested changes
Apr 2, 2025
Collaborator
fourls
left a comment
fourls
left a comment
There was a problem hiding this comment.
Looks like some great changes that will really improve the consistency of this code. I have a few thoughts but overall looks great.
delphi-frontend/src/main/java/au/com/integradev/delphi/antlr/ast/token/DelphiTokenImpl.java
Outdated
Show resolved
Hide resolved
delphi-frontend/src/main/java/au/com/integradev/delphi/preprocessor/DelphiPreprocessor.java
Outdated
Show resolved
Hide resolved
delphi-frontend/src/main/java/au/com/integradev/delphi/preprocessor/DelphiPreprocessor.java
Outdated
Show resolved
Hide resolved
delphi-frontend/src/main/java/au/com/integradev/delphi/preprocessor/PreprocessorException.java
Show resolved
Hide resolved
delphi-frontend/src/main/java/au/com/integradev/delphi/preprocessor/DelphiPreprocessor.java
Outdated
Show resolved
Hide resolved
cirras
force-pushed
the
improve_parsing_error_reporting
branch
from
92ebaba to
e02b121
Compare
Line information was incorrect or incomplete in some cases: - within include files - within compiler directives - when include processing fails due to self-referencing include files This was discovered due to the new `ParsingError` check triggering file pointer errors when trying to raise issues on included tokens.
cirras
force-pushed
the
improve_parsing_error_reporting
branch
from
e02b121 to
dc619c2
Compare
fourls
approved these changes
Apr 3, 2025
Collaborator
fourls
left a comment
fourls
left a comment
There was a problem hiding this comment.
Looks good! The optimization was a good idea.
cirras
added a commit
that referenced
this pull request
Apr 8, 2025
This constructor became unused with #356 when we started creating `IncludeToken` instances at lex-time.
cirras
added a commit
that referenced
this pull request
Apr 8, 2025
This constructor became unused with #356 when we started creating `IncludeToken` instances at lex-time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line information was incorrect or incomplete in some cases:
This was discovered due to the new
ParsingErrorcheck triggering file pointer errors when trying to raise issues on included tokens.