Rewrite MSBuild parsing for improved language support #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fourls
force-pushed
the
msbuild
branch
2 times, most recently
from
1595bc7 to
8cd385f
Compare
cirras
requested changes
May 1, 2025
Collaborator
cirras
left a comment
cirras
left a comment
There was a problem hiding this comment.
I'm seeing a lot of parameters that look like MSBuildState properties, I think we should rename them all to state.
delphi-frontend/src/main/java/au/com/integradev/delphi/msbuild/DelphiMSBuildUtils.java
Outdated
Show resolved
Hide resolved
delphi-frontend/src/main/java/au/com/integradev/delphi/msbuild/MSBuildItem.java
Show resolved
Hide resolved
delphi-frontend/src/main/java/au/com/integradev/delphi/msbuild/MSBuildParser.java
Outdated
Show resolved
Hide resolved
delphi-frontend/src/main/java/au/com/integradev/delphi/msbuild/MSBuildParser.java
Show resolved
Hide resolved
...-frontend/src/main/java/au/com/integradev/delphi/msbuild/expression/ExpressionEvaluator.java
Show resolved
Hide resolved
cirras
requested changes
May 6, 2025
Collaborator
cirras
left a comment
cirras
left a comment
There was a problem hiding this comment.
Looks great, let's get a CHANGELOG entry.
This rewrite adds support for - Items - Item metadata expressions - Well-known properties and metadata - Improved property and item handling - Improved conditional expression evaluation
Collaborator
Author
|
Updated with changelog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrite adds support for
These features don't typically turn up in Delphi project files, but they theoretically can - they are handled correctly by the IDE and so should be supported by our parser.