Add check for array iterations where the high bound is out of range #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I'd definitely lean towards the default quality profile since this is a common bug pattern. |
CoppensBart
reviewed
Apr 23, 2025
...hi-checks/src/test/java/au/com/integradev/delphi/checks/IterationPastHighBoundCheckTest.java
Show resolved
Hide resolved
Collaborator
Author
|
cirras
requested changes
Apr 28, 2025
Collaborator
cirras
left a comment
cirras
left a comment
There was a problem hiding this comment.
In the interest of leaning away from false positives, I think we should make this rule more conservative and only flag cases where low = 0 and high = count.
We can then iteratively make it smarter and broader if we see ways to do so without introducing noise/FPs.
Collaborator
Author
|
Updated to only flag cases where low = 0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95. I haven't added this to the Sonar way quality profile, but it probably could be added depending on how noisy it is. I'll run some tests and see.