Disambiguate index property read/write methods correctly #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fourls
force-pushed
the
fix-index-read-write
branch
from
ad422f8 to
03157e1
Compare
Collaborator
Author
|
Renamed a variable for consistency. |
fourls
force-pushed
the
fix-index-read-write
branch
from
03157e1 to
da9f409
Compare
Collaborator
Author
|
Disregard my fail-on-upgrade test, I found out why it didn't work 🤦 |
cirras
requested changes
May 7, 2025
Collaborator
cirras
left a comment
cirras
left a comment
There was a problem hiding this comment.
Nice - all looks good.
As is tradition, I have a changelog nitpick.
fourls
force-pushed
the
fix-index-read-write
branch
from
da9f409 to
584eb2f
Compare
cirras
requested changes
May 7, 2025
delphi-frontend/src/test/resources/au/com/integradev/delphi/symbol/Properties.pas
Outdated
Show resolved
Hide resolved
When a property has an `index` specifier, its `read` specifier must be a function with an `Integer` final argument, and its `write` specifier must be a procedure with an `Integer` second-last argument. We were not previously modelling this behaviour, causing `read` and `write` specifier methods to fail to resolve when an `index` property is present.
fourls
force-pushed
the
fix-index-read-write
branch
from
584eb2f to
7219b51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a property has an
indexspecifier, itsreadspecifier must be a function with anIntegerfinal argument, and itswritespecifier must be a procedure with anIntegersecond-last argument. We were not previously modelling this behaviour, causingreadandwritespecifier methods to fail to resolve when anindexproperty is present.