Skip to content

Conversation

@fourls
Copy link
Collaborator

@fourls fourls commented May 7, 2025

When a property has an index specifier, its stored specifier must be a function with a single Integer argument.

@fourls fourls requested a review from cirras May 7, 2025 07:19
@fourls
Copy link
Collaborator Author

fourls commented May 7, 2025

I've also fixed the duplicate processing of the stored expression, but not the others since that's covered by #377.

@fourls fourls force-pushed the fix-index-stored branch from 7f83ebf to 833832e Compare May 7, 2025 07:21
@cirras cirras force-pushed the fix-index-stored branch from 833832e to 7adc5fd Compare May 7, 2025 11:02
When a property has an `index` specifier, its `stored` specifier must be
a function with a single `Integer` argument.
@cirras
Copy link
Collaborator

cirras commented May 7, 2025

I've also fixed the duplicate processing of the stored expression, but not the others since that's covered by #377.

This actually failed the StoredProperties test (featuring a stored specifier backed by a constant) because the top-level PropertyNode visit calls disambiguateParameters and erroneously eliminates non-invocable declarations.

I've restored the double-visit by the SymbolTableVisitor.

I'll rebase #377 over these changes and fix the double-visit of stored in the same commit read and write.

@cirras cirras force-pushed the fix-index-stored branch from 7adc5fd to 436014f Compare May 7, 2025 11:08
@cirras cirras merged commit 347508b into master May 7, 2025
4 checks passed
@cirras cirras deleted the fix-index-stored branch May 7, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants