Fix various type resolution failures #384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cirras
requested changes
May 13, 2025
delphi-frontend/src/main/java/org/sonar/plugins/communitydelphi/api/ast/TypeParameterNode.java
Outdated
Show resolved
Hide resolved
cirras
requested changes
May 13, 2025
delphi-frontend/src/main/java/au/com/integradev/delphi/symbol/resolve/NameResolver.java
Outdated
Show resolved
Hide resolved
Previously, we were resolving all type parameter constraints before resolving the type parameters themselves. This resulted in unresolved types in cases where a later type parameter relied on a previous type parameter.
We were previously not specializing type constraints, which was resulting in the constraint checking the unspecialized type parameter type for compatibility with the specialized type, which would always fail.
fourls
force-pushed
the
fix-generic-resolution
branch
from
d526c2e to
f824cc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes:
ascasts where the type expression is a function (e.g.GetFooClass)TFooClass.Create, which creates aTFoo)