Skip to content

Conversation

@fourls
Copy link
Collaborator

@fourls fourls commented Jul 24, 2025

Fixes #99.

@fourls fourls requested a review from cirras July 24, 2025 07:24
@fourls fourls force-pushed the interface-parameters branch from 329bab4 to 32db218 Compare July 28, 2025 06:35
@fourls fourls requested a review from cirras July 28, 2025 06:35
@fourls fourls force-pushed the interface-parameters branch from 32db218 to 692dd4b Compare July 29, 2025 06:36
Copy link
Collaborator

@cirras cirras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs a CHANGELOG entry.

@fourls fourls force-pushed the interface-parameters branch from 692dd4b to 82f43b5 Compare July 30, 2025 02:12
@fourls fourls requested a review from cirras July 30, 2025 02:12
Copy link
Collaborator

@cirras cirras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@cirras cirras merged commit fb83d2f into master Jul 30, 2025
4 checks passed
@cirras cirras deleted the interface-parameters branch July 30, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New rule: Class instance variables should not be passed as an interface parameter

3 participants